Fix #333, Relative strict-dir-list for static analysis workflow #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
CCB:Ready
astrogeco
added
CCB:Approved
|
CCB:2022-04-13 APPROVED |
astrogeco
added a commit
that referenced
this pull request
Apr 18, 2022
Fix #333, Relative strict-dir-list for static analysis workflow
|
@skliper this seems to be failing even thouth nasa/cFS#454 is merged. See 55a575e I was able to make it pass by removing the jobs:
static-analysis:
name: Run cppcheck
uses: nasa/cFS/.github/workflows/static-analysis.yml@main
with:
strict-dir-list: 'fsw' |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 18, 2022
nasa/PSP#334, Fix input to static analysis workflow
|
Just to follow up, the failure seems to have been due to just rerunning the failed job which didn't pull in the new reusable workflow. Then after removing the leading |
astrogeco
added a commit
to astrogeco/PSP
that referenced
this pull request
Apr 19, 2022
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 19, 2022
nasa/PSP#334, Fix input to static analysis workflow
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 19, 2022
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Justing Figueroa <[email protected]>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 19, 2022
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Justing Figueroa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Testing performed
Needs nasa/cFS#454 in main to actually test with CI
Expected behavior changes
Will work once nasa/cFS#454 is in
System(s) tested on
CI
Additional context
Depends on nasa/cFS#454, similar update as what's implemented in nasa/CF#228
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC